Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockernet Host Chain ID #410

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Dockernet Host Chain ID #410

merged 1 commit into from
Dec 1, 2022

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Nov 29, 2022

Closes: #XXX

Context and purpose of the change

The HOST_CHAINS config variable was in start_network.sh, but it should be with the other config variables in vars.sh.

Also, the chain name (i.e. STRIDE, GAIA, JUNO, etc) was often conflated with the chain-id. This PR makes the distinction which allows the adding of host chains that have more stringent restrictions on their chain ID.

Brief Changelog

  • Moved HOST_CHAINS to vars.sh
  • Grabbed chain ID from vars.sh instead of using the chain name everywhere
  • Removed stargaze from integration tests. There are diminishing returns of running more than 3 host zones. It's computationally expensive and does not add much value.

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@sampocs sampocs added the cleanup Code cleanup without breaking changes label Nov 29, 2022
@sampocs sampocs requested a review from a team November 29, 2022 21:56
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sampocs sampocs merged commit df2fcea into main Dec 1, 2022
sontrinh16 pushed a commit to notional-labs/stride that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup without breaking changes T:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants