Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sdk and tendermint, don't use the debug sdk #278

Closed
wants to merge 6 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 15, 2022

Context and purpose of the change

Part of our code cleanup effort:

  • discontinue use of the debug sdk branch
  • bump tendermint to v0.34.21
  • remove unneded starport replace

Brief Changelog

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@Highlander-maker
Copy link

I have ran this on my validator after seeing some strange logs. See below

Screenshot 2022-09-18 at 16 22 52

I reached out to @faddat and we have used this branch on my mainnet validator and it is working great. The bad logs are now gone. This is a non-state breaking upgrade so it can be merged right away. :).

@asalzmann
Copy link
Contributor

The only change we have in our "debug" sdk is basically this: cosmos/cosmos-sdk#11960

Once this is merged, we could switch over to the stock sdk, but we're making some changes to the distribution module so we're going to have to switch back over to our version soon. It might make more sense to use a cleaner tag name?

Is there a benefit of changing back to the standard sdk? @Highlander-maker do you know why this branch resolved your issues?

@asalzmann
Copy link
Contributor

@faddat can we bump tendermint without bumping the sdk?

@Highlander-maker
Copy link

I've logged in to node and it's sad to say after some more monitoring we are still receiving these crazy large logs after some blocks being produced.

I will take more notes tomorrow and discuss with @faddat. Apologies for the late update.

@asalzmann
Copy link
Contributor

Can you send me one of the logs? Also happy to chat offline.

@faddat
Copy link
Contributor Author

faddat commented Sep 24, 2022

Hey guys, the right way to do things would be to bump tendermint, and if you want to use a modified SDK, then you should make some modifications on top of SDK v 0.45.8

@faddat
Copy link
Contributor Author

faddat commented Oct 6, 2022

this is a highly impactful PR, performance-wise

@faddat faddat changed the title bump sdk and tendermint, don't use the debug sdk bump: sdk and tendermint, don't use the debug sdk Oct 6, 2022
@faddat faddat changed the title bump: sdk and tendermint, don't use the debug sdk chore: sdk and tendermint, don't use the debug sdk Oct 6, 2022
@asalzmann
Copy link
Contributor

I see - I'll push up a new sdk tag (on 45.8) and add a replace here

@asalzmann
Copy link
Contributor

I think this is resolved by #301

@asalzmann asalzmann closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants