-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sdk and tendermint, don't use the debug sdk #278
Conversation
I have ran this on my validator after seeing some strange logs. See below I reached out to @faddat and we have used this branch on my mainnet validator and it is working great. The bad logs are now gone. This is a non-state breaking upgrade so it can be merged right away. :). |
The only change we have in our "debug" sdk is basically this: cosmos/cosmos-sdk#11960 Once this is merged, we could switch over to the stock sdk, but we're making some changes to the distribution module so we're going to have to switch back over to our version soon. It might make more sense to use a cleaner tag name? Is there a benefit of changing back to the standard sdk? @Highlander-maker do you know why this branch resolved your issues? |
@faddat can we bump tendermint without bumping the sdk? |
I've logged in to node and it's sad to say after some more monitoring we are still receiving these crazy large logs after some blocks being produced. I will take more notes tomorrow and discuss with @faddat. Apologies for the late update. |
Can you send me one of the logs? Also happy to chat offline. |
Hey guys, the right way to do things would be to bump tendermint, and if you want to use a modified SDK, then you should make some modifications on top of SDK v 0.45.8 |
this is a highly impactful PR, performance-wise |
I see - I'll push up a new sdk tag (on 45.8) and add a replace here |
I think this is resolved by #301 |
Context and purpose of the change
Part of our code cleanup effort:
Brief Changelog
Author's Checklist
I have...
If skipped any of the tests above, explain.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Documentation and Release Note
Unreleased
section inCHANGELOG.md
?How is the feature or change documented?
XXX
x/<module>/spec/
)