Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtitles size and offset for StreamItemState #735

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Add subtitles size and offset for StreamItemState #735

merged 5 commits into from
Nov 14, 2024

Conversation

tymmesyde
Copy link
Member

No description provided.

@kKaskak kKaskak self-requested a review November 13, 2024 15:53
elpiel
elpiel requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only changes that should guard against failing deserialization of already existing StreaamItemStates in the StreamsBucket

@elpiel elpiel merged commit 47059b1 into development Nov 14, 2024
5 checks passed
@elpiel elpiel mentioned this pull request Nov 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kKaskak kKaskak kKaskak approved these changes

@elpiel elpiel elpiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tymmesyde @elpiel @kKaskak