feat: Profile Settings - controls & esc for exiting fullscreen #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
requested review from
TheBeastLT and
tymmesyde
and removed request for
TheBeastLT
tymmesyde
requested changes
Oct 24, 2023
TheBeastLT
reviewed
Oct 24, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
TheBeastLT
approved these changes
Oct 24, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
tymmesyde
approved these changes
Oct 24, 2023
elpiel
deleted the
feat/profile-settings-for-control-and-exit-fullscreen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seek_short_time_durationfor short (finer) seeking (e.g. using Arrow + Shift) and with default value of - 3 secondsEscape key exiting Full screenof the appPause playback on minimizeDiscussed on Slack: Since most players have default seeking time of 10 seconds we will keep this default and instead provide a finer seek time of 3 seconds.
Related issue: Stremio/stremio-web#413