feat: MetaDetails - guess streams only when a flag is present #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows you to load the MeteDetails without loading streams.
Previous feature allowed the guessing of the streams if a stream_path was not provided - see #474, but there are cases in the apps where we load the
MetaDetails
but we don't actually want to load the streams as we only show a small modal with just a few things from the MetaDetails like the Trailer.We now have 4 code cases:
stream_path: Some
and we haveguess_stream: false
- loads the stream from the provided pathstream_path: Some
andguess_stream: true
- loads the stream from the provided path ignoring theguess_stream: true
stream_path: None
andguess_stream: true
- guesses thestream_path
using the first successfully loadedMetaItem
stream_path: None
andguess_stream: false
- no streams will be loaded for theMetaDetails