Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MetaDetails - guess streams only when a flag is present #540

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Oct 20, 2023

This feature allows you to load the MeteDetails without loading streams.
Previous feature allowed the guessing of the streams if a stream_path was not provided - see #474, but there are cases in the apps where we load the MetaDetails but we don't actually want to load the streams as we only show a small modal with just a few things from the MetaDetails like the Trailer.

We now have 4 code cases:

  1. stream_path: Some and we have guess_stream: false - loads the stream from the provided path
  2. stream_path: Some and guess_stream: true - loads the stream from the provided path ignoring the guess_stream: true
  3. stream_path: None and guess_stream: true - guesses the stream_path using the first successfully loaded MetaItem
  4. stream_path: None and guess_stream: false - no streams will be loaded for the MetaDetails

src/models/meta_details.rs Show resolved Hide resolved
@tymmesyde
Copy link
Member

Maybe guess_stream true by default since it's the intended behavior ?

@elpiel
Copy link
Member Author

elpiel commented Oct 23, 2023

Maybe guess_stream true by default since it's the intended behavior ?

no, it's not. The value true should be taken into account only when stream_path is None

@elpiel elpiel changed the title feat: MetaDetails - override streams only when a flag is present feat: MetaDetails - guess streams only when a flag is present Oct 23, 2023
@elpiel elpiel merged commit a8a24d0 into development Oct 23, 2023
1 check passed
@elpiel elpiel deleted the feat/streams-loading-in-meta-details branch October 23, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants