Skip to content

Commit

Permalink
fix: typo for esc exit fullscreen
Browse files Browse the repository at this point in the history
Signed-off-by: Lachezar Lechev <[email protected]>
  • Loading branch information
elpiel committed Oct 24, 2023
1 parent e19fe25 commit 75164cd
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/runtime/env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ fn migrate_storage_schema_to_v9<E: Env>() -> TryEnvFuture<()> {
);

// add the new setting for Escape key exiting full screen
settings.insert("escExistFullscreen".to_owned(), true.into());
settings.insert("escExitFullscreen".to_owned(), true.into());
// add the new setting for pause on minimize, which is disabled by default
settings.insert("pauseOnMinimize".to_owned(), false.into());
E::set_storage(PROFILE_STORAGE_KEY, Some(&profile))
Expand Down Expand Up @@ -833,7 +833,7 @@ mod test {

let migrated_profile = json!({
"settings": {
"escExistFullscreen": true,
"escExitFullscreen": true,
"seekShortTimeDuration": 3000,
"pauseOnMinimize": false,
}
Expand Down
4 changes: 2 additions & 2 deletions src/types/profile/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pub struct Settings {
pub subtitles_background_color: String,
pub subtitles_outline_color: String,
/// Whether or not the Escape key should exists from the app when in Full screen.
pub esc_exist_fullscreen: bool,
pub esc_exit_fullscreen: bool,
/// The Seek time duration (in milliseconds) is when using the Arrow keys
pub seek_time_duration: u32,
/// The Seek short time duration (in milliseconds) is when we are finer seeking,
Expand Down Expand Up @@ -68,7 +68,7 @@ impl Default for Settings {
subtitles_text_color: "#FFFFFFFF".to_owned(),
subtitles_background_color: "#00000000".to_owned(),
subtitles_outline_color: "#000000".to_owned(),
esc_exist_fullscreen: true,
esc_exit_fullscreen: true,
seek_time_duration: 10000,
seek_short_time_duration: 3000,
pause_on_minimize: false,
Expand Down
2 changes: 1 addition & 1 deletion src/unit_tests/serde/default_tokens_ext.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ impl DefaultTokens for Settings {
Token::Str("#00000000"),
Token::Str("subtitlesOutlineColor"),
Token::Str("#000000"),
Token::Str("escExistFullscreen"),
Token::Str("escExitFullscreen"),
Token::Bool(true),
Token::Str("seekTimeDuration"),
Token::U32(10000),
Expand Down
6 changes: 3 additions & 3 deletions src/unit_tests/serde/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fn settings() {
subtitles_text_color: "subtitles_text_color".to_owned(),
subtitles_background_color: "subtitles_background_color".to_owned(),
subtitles_outline_color: "subtitles_outline_color".to_owned(),
esc_exist_fullscreen: true,
esc_exit_fullscreen: true,
seek_time_duration: 10,
seek_short_time_duration: 3,
pause_on_minimize: true,
Expand Down Expand Up @@ -86,7 +86,7 @@ fn settings() {
Token::Str("subtitles_background_color"),
Token::Str("subtitlesOutlineColor"),
Token::Str("subtitles_outline_color"),
Token::Str("escExistFullscreen"),
Token::Str("escExitFullscreen"),
Token::Bool(true),
Token::Str("seekTimeDuration"),
Token::U32(10),
Expand Down Expand Up @@ -150,7 +150,7 @@ fn settings_de() {
Token::Str("#00000000"),
Token::Str("subtitlesOutlineColor"),
Token::Str("#000000"),
Token::Str("escExistFullscreen"),
Token::Str("escExitFullscreen"),
Token::Bool(true),
Token::Str("seekTimeDuration"),
Token::U32(10000),
Expand Down

0 comments on commit 75164cd

Please sign in to comment.