-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterfaceConfiguration encode/decode matches spec... but not reality #4
Comments
Thanks for the feedback. I've started a heavy refactoring of the library which will support multiple ALP versions, thus will allow supporting ALP implementations deviating from the specification. In the meantime, I've created a branch (ref_compat) whose purpose is to be compatible with Sub-IoT-Stack. I'll publish that "reference compatible" library with the version scheme: Do you have a way to test the compatibility of this new release with the Sub-IoT-Stack implementation? |
I have local work which exercises your code against a local SubIoT stack installation on an STM board. I'll check your branch later today. |
I believe the serial communication layer should be written as a separate library. I know of another proprietary dash7 stack implementation and I think it uses a different serial communication protocol (I'll double check later). If you end up writing a library for the serial communication of the open source implementation, I'd gladly add a link to it in the README of this library. |
Ok your changes seem to work for me. One caveat is that I'm having issues with multiple request file commands in sequence (RequestFileData in a loop), the second result seems to not come back correctly. I'm suspecting there's potentially another similar issue somewhere in another message which I'll try to diagnose today by comparing byte by byte to the reference implementation again. In the meantime the Sub-IoT people have acknowledged the "TE" issue with the spec and hopefully will work out some way to fix it in the reference implementation while also providing backward compat. |
closed by #30 |
As I discovered and reported to SubIoT team: Sub-IoT/Sub-IoT-Stack#129
Your implementation is technically correct (the best kind of correct).
But in reality the 'TE' byte is not properly parsed or produced by the reference implementation in C or the pyd7a library in Python. So 'Forward' action packets produced using your library will not be processed correctly by the gateway.
Not sure what the right thing to do here is.
The text was updated successfully, but these errors were encountered: