Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build arg and build context args #167

Merged
merged 4 commits into from
Dec 30, 2023
Merged

add build arg and build context args #167

merged 4 commits into from
Dec 30, 2023

Conversation

khizunov
Copy link
Contributor

No description provided.

@khizunov khizunov requested a review from ofir-amir December 26, 2023 06:35
@khizunov khizunov force-pushed the anton/add-build-arg-and-context branch from 9c0f32c to 687ccca Compare December 26, 2023 06:39
@ofir-amir ofir-amir requested a review from eranco74 December 26, 2023 11:22
ofir-amir
ofir-amir reviewed Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@ofir-amir ofir-amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundling of lint fixes and other fixes make it hard to read

README.md Show resolved Hide resolved
@khizunov
Copy link
Contributor Author

The bundling of lint fixes and other fixes make it hard to read

Guilty, forgot to disable auto-format.

@khizunov khizunov force-pushed the anton/add-build-arg-and-context branch 3 times, most recently from acd9afb to ed0b246 Compare December 26, 2023 14:36
@ofir-amir ofir-amir self-requested a review December 27, 2023 06:15
ofir-amir
ofir-amir requested changes Dec 27, 2023
View reviewed changes
skipper.yaml Outdated Show resolved Hide resolved
skipper/cli.py Outdated Show resolved Hide resolved
skipper/cli.py Show resolved Hide resolved
tests/test_cli.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this test config from skipper.yaml only or also from CLI or you expect to be handled by click?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofir-amir this test is testing builder functionality.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - the question was on tests/test_config.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests are only for config file. CLI verified by test_cli

@khizunov khizunov force-pushed the anton/add-build-arg-and-context branch from ed0b246 to 6c87cbb Compare December 27, 2023 12:46
@ofir-amir ofir-amir self-requested a review December 28, 2023 06:51
@khizunov khizunov merged commit 8fa3634 into upstream Dec 30, 2023
3 checks passed
@khizunov khizunov deleted the anton/add-build-arg-and-context branch December 30, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofir-amir ofir-amir ofir-amir approved these changes

@eranco74 eranco74 Awaiting requested review from eranco74

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khizunov @ofir-amir