Support wheels distribution #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @eranco74 |
|
Sort of reverts #42 |
Seems like the comment about data files not being included in wheels when using full paths is no longer true. The check I've done is making sure the completion output still works when installing the wheel files, which seems to work. In addition, it produces warnings that the legacy installation method will get deprecated soon: ``` DEPRECATION: strato-skipper was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 23.1 will enforce this behaviour change. ```
osherdp
force-pushed
the
feature/support-wheel-distribution
branch
from
0b8ede5 to
bf9528f
Compare
eranco74
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the comment about data files not being included in wheels when using full paths is no longer true.
The check I've done is making sure the completion output still works when installing the wheel files, which seems to work.
In addition, it produces warnings that the legacy installation method will get deprecated soon: