Don't use shared bind mounts #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernand
force-pushed
the
dont_use_shared_bind_mounts
branch
from
212f8c6 to
31e0778
Compare
|
/lgtm |
Currently podman is invoked with options to mount both the workspace directory and some of the files it contains. For example, if the workspace is `/root`: ``` -v /root/.netrc:/root/.netrc:ro -v /root:/root:rw,shared ``` The workspace directory is mounted using the _shared_ option. This results in leaking mount points at an exponential rate, as descrived in this _podman_ issue (no closed, as it is the expected behaviour): containers/podman#15671 This _shared_ option is not really needed. This patch removes it. Signed-off-by: Juan Hernandez <[email protected]>
jhernand
force-pushed
the
dont_use_shared_bind_mounts
branch
from
31e0778 to
19662cf
Compare
eranco74
approved these changes
Sep 8, 2022
jhernand
added a commit
to jhernand/assisted-test-infra
that referenced
this pull request
Sep 8, 2022
The more relevant change in the new version of _skipper_ is a fix to prevent leaking of mount points. Related: Stratoscale/skipper#155 Related: containers/podman#15671 Signed-off-by: Juan Hernandez <[email protected]>
openshift-merge-robot
pushed a commit
to openshift/assisted-test-infra
that referenced
this pull request
Sep 8, 2022
The more relevant change in the new version of _skipper_ is a fix to prevent leaking of mount points. Related: Stratoscale/skipper#155 Related: containers/podman#15671 Signed-off-by: Juan Hernandez <[email protected]> Signed-off-by: Juan Hernandez <[email protected]>
CrystalChun
pushed a commit
to CrystalChun/assisted-test-infra
that referenced
this pull request
Sep 8, 2022
The more relevant change in the new version of _skipper_ is a fix to prevent leaking of mount points. Related: Stratoscale/skipper#155 Related: containers/podman#15671 Signed-off-by: Juan Hernandez <[email protected]> Signed-off-by: Juan Hernandez <[email protected]>
CrystalChun
pushed a commit
to CrystalChun/assisted-test-infra
that referenced
this pull request
Sep 8, 2022
The more relevant change in the new version of _skipper_ is a fix to prevent leaking of mount points. Related: Stratoscale/skipper#155 Related: containers/podman#15671 Signed-off-by: Juan Hernandez <[email protected]> Signed-off-by: Juan Hernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently podman is invoked with options to mount both the workspace directory and some of the files it contains. For example, if the workspace is
/root:The workspace directory is mounted using the shared option. This results in leaking mount points at an exponential rate, as described in this podman issue (now closed, as it is the expected behaviour):
containers/podman#15671
This shared option is not really needed. This patch removes it.