Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EOS-11130] Handle keos domain parameter #94

Conversation

esierra-stratio
Copy link

AWS

keos.domain always takes the value of cluster.local

GCP and others

if spec.keos.domain has a value in cluster.yaml keos.domain takes always that value in keos.yaml
if spec.keos.domain doesn't exist in cluster.yaml keos.domain will not exist in keos.yaml (by default in keos-installer it will take the default value of $cluster_id.int)

Copy link

@dandres-stratio dandres-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamjanr iamjanr self-requested a review April 18, 2023 08:35
Copy link

@iamjanr iamjanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esierra-stratio esierra-stratio merged commit 6d52936 into Stratio:branch-0.17.0-0.2 Apr 19, 2023
@esierra-stratio esierra-stratio deleted the chore/keos_domain_parameter_upport branch April 19, 2023 08:17
@stg-0 stg-0 added the 0.2.0 label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants