added permission to save resource. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geist5000
commented
Aug 16, 2022
| "save_id" => $this->id, | ||
| "permission" => $this->pivot->permission, | ||
| "save" => new SimplerSaveResource($this->resource), | ||
| $this->merge(new PermissionResource($this->pivot)) |
There was a problem hiding this comment.
This is a breaking change
nic-schi
requested changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The save show and user showSaves route now returns the permission with every save which isn't owned by the authenticated user.
BREAKING CHANGES:
UserResource -> now returns save with tool and user data instead of save_id in invited and shared save