Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added test for claiming rewards on 0 deposit gauge #331

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lilPlumberBoy
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Title follows conventional commits style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Newly added functions follow Check-effects-interaction
  • Gas usage has been minimized (ex. Storage variable access is minimized)

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

github-actions bot commented Apr 12, 2024

Changes to gas cost

Generated at commit: 239807507273a3d81a45f0a15841804f0a10c0e1, compared to commit: ad94bf05f570ab421122db1e6391caa4739fe297

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
ERC20RewardsGauge deposit +856 ❌ +0.89%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20RewardsGauge 3,604,944 (0) addReward
claimRewards
deposit
depositRewardToken
getRewardData
grantRole
initialize
renounceRole
3,053 (0)
5,685 (0)
2,755 (0)
7,707 (0)
1,664 (0)
72,558 (0)
2,992 (0)
5,206 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
67,575 (+277)
152,733 (-1,753)
97,357 (+856)
148,411 (-57)
3,032 (-39)
72,898 (+8)
313,885 (+165)
6,426 (+33)
+0.41%
-1.13%
+0.89%
-0.04%
-1.27%
+0.01%
+0.05%
+0.52%
73,470 (0)
100,941 (0)
93,699 (+14,310)
147,383 (0)
1,664 (0)
72,558 (0)
449,126 (0)
5,206 (0)
0.00%
0.00%
+18.03%
0.00%
0.00%
0.00%
0.00%
0.00%
73,470 (0)
923,524 (0)
216,659 (0)
195,467 (0)
11,664 (0)
79,358 (0)
543,836 (0)
34,206 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
5,705 (+256)
4,097 (+256)
5,122 (+256)
4,866 (+256)
5,398 (+512)
1,677 (+2)
837 (+1)
1,663 (+2)
YearnStakingDelegate 3,689,914 (0) execute 27,929 (0) 0.00% 136,787 (+73) +0.05% 149,225 (0) 0.00% 149,609 (0) 0.00% 268 (0)
CoveToken 3,495,457 (0) addAllowedReceiver
mint
removeAllowedSender
26,282 (0)
26,613 (0)
31,020 (0)
0.00%
0.00%
0.00%
50,931 (-1)
67,129 (-1)
42,439 (-1)
-0.00%
-0.00%
-0.00%
55,323 (0)
75,549 (0)
31,248 (0)
0.00%
0.00%
0.00%
55,335 (0)
98,393 (0)
53,829 (0)
0.00%
0.00%
0.00%
1,793 (0)
1,537 (0)
513 (0)
MasterRegistry 1,462,573 (0) multicall 173,014 (0) 0.00% 176,528 (+1) +0.00% 176,386 (+6) +0.00% 179,746 (0) 0.00% 512 (0)
YearnGaugeStrategy 1,817,865 (0) report 58,515 (0) 0.00% 303,088 (-1) -0.00% 69,644 (0) 0.00% 914,862 (0) 0.00% 5,890 (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant