Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first rough adaption of published massage with header #7

Open
wants to merge 3 commits into
base: distributed_control_aio
Choose a base branch
from

Conversation

mamueluth
Copy link
Member

changes for command side, publishing missing

add time and publishing of when command is received

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@mergify
Copy link

mergify bot commented Jun 14, 2023

This pull request is in conflict. Could you fix it @mamueluth?

@mamueluth mamueluth force-pushed the distributed_control_aio_header_time branch 2 times, most recently from 0023e3e to b2f8f91 Compare June 14, 2023 13:10
@mamueluth mamueluth force-pushed the distributed_control_aio_header_time branch from b2f8f91 to 60e0a9a Compare June 14, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant