-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passwords, Windows, and Error bubbling, oh my #21
Conversation
I think I'm done with this. Please let me know if you have any feedback or changes. Would love to be able to include a new version of this lib properly in my app! |
Oh, very nice! Could you update the README with the two new connection options? I also thought about tests for the windows agent detection, but I assume that you are using this feature already, so it must be working ;) |
Sure! Actually haven't tested the windows agent yet, but it is according to the docs. It should be tested in the next couple of days |
A few more changes
|
Honestly, it probably shouldn't read |
Awesome, thank you so much for the contribution! Your PR will land as |
Thanks! Also - confirmed Pageant is working :-) |
FYI - Love this library, by far the simplest and most obvious implementation of a SSH tunnel library. Thank you for making it!
Included in this PR: