Update danger to the latest version 🚀 #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Danger has erroredError: Error Error: Cannot find module 'package.json'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at getBabelRC (/home/travis/build/StoDevX/AAO-React-Native/node_modules/babel-jest/build/index.js:53:41)
at Object.getCacheKey (/home/travis/build/StoDevX/AAO-React-Native/node_modules/babel-jest/build/index.js:90:14)
at ScriptTransformer._getCacheKey (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:68:26)
at ScriptTransformer._getFileCachePath (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:93:27)
at ScriptTransformer.transformSource (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:182:32)
at ScriptTransformer._transformAndBuildScript (/home/travis/build/StoDevX/AAO-React-Native/node_modules/jest-runtime/build/ScriptTransformer.js:275:40)Generated by 🚫 dangerJS |
|
Uh. |
|
We don't ask for package.json in our dangerfile. And, from reading that stack, it look like it's coming from inside danger's jest depdency? Hmm. |
|
I'm pretty sure that we're running into danger/danger-js#261 |
Version 0.20.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 22 commits.
There are 22 commits in total. See the full diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.19.0 of danger just got published.
The version 0.19.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of danger.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 33 commits.
821c682Version bump for 0.19 and a dangerfile update7648899Merge pull request #254 from danger/greenkeeper/typescript-2.3.3cc4ead9Merge pull request #256 from danger/240-markdown-commentsd200bbachore(package): update typescript to version 2.3.37630fd2chore(package): update tslint to version 5.3.0 (#257)63051ddRender markdown inside violations9a50150Merge pull request #247 from danger/docs_lint8e5e4d9Make dts lint optional598db10More DTS faffing, and updates changelog9718f29Add DTS linter to travisb09f6c7Add support for ensuring the dts passes all linters etc5658734Convert the d.ts to always use thing[] vs Array as the dts linter was raising776fbd9Merge pull request #246 from danger/update-jest93eff6eUpdate to Jest 20b78c16dMerge pull request #239 from danger/docs_lintThere are 33 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴