Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): Update dependency eslint-config-prettier to v8 - abandoned #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 8, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-prettier 6.x -> 8.x age adoption passing confidence

Release Notes

prettier/eslint-config-prettier

v8.7.0

Compare Source

v8.6.0

Compare Source

  • Added: [vue/multiline-ternary]. Thanks to @​xcatliu!

v8.5.0

Compare Source

v8.4.0

Compare Source

v8.3.0

Compare Source

v8.2.0

Compare Source

  • Added: [flowtype/quotes]. Thanks to Martin Zlámal (@​mrtnzlml)!

v8.1.0

Compare Source

  • Added: [flowtype/object-type-curly-spacing].
  • Added: Dummy files for the configs removed in 8.0.0. The dummy files throw an error that try to guide you how to upgrade.

v8.0.0

Compare Source

  • Changed: All configs have been merged into one!

    To upgrade, change:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier",
        "prettier/@​typescript-eslint",
        "prettier/babel",
        "prettier/flowtype",
        "prettier/react",
        "prettier/standard",
        "prettier/unicorn",
        "prettier/vue"
      ]
    }

    Into:

    {
      "extends": [
        "some-other-config-you-use",
        "prettier"
      ]
    }

    The "prettier" config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!

    So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@​lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@​thorn0) for pointing this out!

    If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:

    {
      "extends": [
        "some-other-config-you-use",
        "plugin:prettier/recommended"
      ]
    }

    (The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main "prettier" config does not include the rules from it.)

  • Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).

v7.2.0

Compare Source

v7.1.0

Compare Source

  • Added: [unicorn/empty-brace-spaces]. Thanks to fisker Cheung (@​fisker)!

v7.0.0

Compare Source

  • Changed: At least ESLint 7.0.0 is now required.

  • Changed: [arrow-body-style] and [prefer-arrow-callback] are no longer turned off by default. They only need to be turned off if you use [eslint-plugin-prettier]. If you do, add "prettier/prettier" to your "extends" array to turn them off again.

    {
      "extends": ["prettier", "prettier/prettier"],
      "plugins": ["prettier"],
      "rules": {
        "prettier/prettier": "error"
      }
    }

    Alternatively, update [eslint-plugin-prettier] to version 3.2.0 or later which automatically turns off these two rules in its "plugin:prettier/recommended" config.

    The CLI helper tool only warns about these rules if you have the "prettier/prettier" rule enabled for a file.

  • Changed: no-tabs is now a validatable rule. If you use it, you should enable allowIndentationTabs so that the rule works regardless of your Prettier config:

    {
      "rules": {
        "no-tabs": ["error", { "allowIndentationTabs": true }]
      }
    }
  • Changed: The CLI helper tool is now called just eslint-config-prettier instead of eslint-config-prettier-check. This is so that npx eslint-config-prettier always works regardless of whether you have already installed eslint-config-prettier or not: If you have, the local installation is used; if you haven’t, npx downloads a temporary copy.

  • Changed: The CLI helper tool no longer requires you to pipe the output of eslint --print-config to it. Instead, it does that automatically for you via ESLint API:s added in ESLint v7.

    Before:

    npx eslint --print-config index.js | npx eslint-config-prettier-check
    

    After:

    npx eslint-config-prettier index.js
    
  • Improved: The npm package is now 75% smaller.

v6.15.0

Compare Source

v6.14.0

Compare Source

  • Added: New [eslint-plugin-vue] rules: [vue/array-bracket-newline] and [vue/block-tag-newline]. Thanks to @​xcatliu!

v6.13.0

Compare Source

  • Added: New rules in [eslint-plugin-vue] 7.0 (which supports Vue 3.0). Thanks to @​xcatliu!

v6.12.0

Compare Source

v6.11.0

Compare Source

v6.10.1

Compare Source

  • Improved: Recommend using npx when running the CLI helper tool.
  • Updated: Mention that eslint-config-prettier has been tested with Prettier 2.0 and the latest versions of plugins.

v6.10.0

Compare Source

v6.9.0

Compare Source

v6.8.0

Compare Source

v6.7.0

Compare Source

v6.6.0

Compare Source

  • Added: New [eslint-plugin-vue] rules: [vue/dot-location] and [vue/keyword-spacing]. Thanks to @​xcatliu!

v6.5.0

Compare Source

  • Added: Support for [excluding deprecated rules]. Thanks to Alex Ilyaev (@​alexilyaev)!

v6.4.0

Compare Source

  • Added: [unicorn/no-nested-ternary]. Thanks to Yang Mingshan (@​yangmingshan)!

v6.3.0

Compare Source

v6.2.0

Compare Source

v6.1.0

Compare Source

  • Added: [function-call-argument-newline] (new in ESLint 6.2.0). Thanks to Masafumi Koba (@​ybiquitous)!

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #716 (3a55924) into master (1ad087f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files           7        7           
  Lines          43       43           
  Branches        8        8           
=======================================
  Hits           32       32           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad087f...87c311d. Read the comment docs.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@renovate renovate bot changed the title feat(deps): Update dependency eslint-config-prettier to v8 feat(deps): Update dependency eslint-config-prettier to v8 - abandoned Aug 5, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Aug 5, 2023

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant