Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves document validator; corrects issues with component tag compilation #26

Merged

Conversation

JohnathonKoster
Copy link
Collaborator

This PR improves the out-of-box experience with the document validator:

  • Resolves an issue where custom Blade component compilers would not be used when compiling documents
  • Corrects an issue preventing some component tag parameters from being compiled succesfully

In addition, this PR makes the following changes:

  • The ignore_directives validation configuration option will now be used to disable parsing and compilation across all validators, for consistency
  • Adds the livewire directive to the list of ignored directives to prevent users from having to add it each time (due to some lifecycle items)

@JohnathonKoster JohnathonKoster merged commit 650c1a8 into master Feb 11, 2024
8 of 12 checks passed
@JohnathonKoster JohnathonKoster deleted the validate-command-failing-on-unrecognized-directives branch October 13, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant