Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieving of port_mapping_number_of_entries for IGDs. #234

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

StevenLooman
Copy link
Owner

Add retrieving of port_mapping_number_of_entries for IGDs. Refs #226

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 23.25581% with 33 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (ee0aac7) to head (c9dc398).

Files Patch % Lines
async_upnp_client/profiles/igd.py 23.25% 33 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #234      +/-   ##
===============================================
- Coverage        72.10%   71.83%   -0.27%     
===============================================
  Files               19       19              
  Lines             4162     4190      +28     
===============================================
+ Hits              3001     3010       +9     
- Misses            1161     1180      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenLooman StevenLooman merged commit 7b6b423 into development Jun 3, 2024
13 of 15 checks passed
@StevenLooman StevenLooman deleted the igd_number_of_port_mappings branch June 3, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant