Fix media_image_url using Resource.url instead of .uri (#244)

StevenLooman · Sep 10, 2024 · 7d61b37 · 7d61b37
1 parent b0a941a
commit 7d61b37
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -2,6 +2,7 @@ name: Build
 
 on:
   - push
+  - pull_request
 
 env:
   publish-python-version: 3.12

diff --git a/async_upnp_client/profiles/dlna.py b/async_upnp_client/profiles/dlna.py
@@ -1208,8 +1208,8 @@ def media_image_url(self) -> Optional[str]:
 
             for res in item.resources:
                 protocol_info = res.protocol_info or ""
-                if protocol_info.startswith("http-get:*:image/"):
-                    return absolute_url(device_url, res.url)
+                if protocol_info.startswith("http-get:*:image/") and res.uri:
+                    return absolute_url(device_url, res.uri)
 
         return None
 

diff --git a/changes/244.bugfix b/changes/244.bugfix
@@ -0,0 +1 @@
+Fix media_image_url using Resource.url instead of .uri (@chishm)
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ name: Build @@
     on:
       - push
+      - pull_request
     env:
       publish-python-version: 3.12
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix media_image_url using Resource.url instead of .uri (@chishm)