FindCSparse: search for headers in PATH_SUFFIXES also in non-standard location #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
The current version of
find_package(CSparse)
can fail with error:when CSparse is not installed in one of the locations hardcoded in the
PATHS
argument offind_path
. For example, it would also fail if you compiled suitesparse inside a colcon workspace instead of installing it from binary .deb packages.CMake's
find_path
offers thePATH_SUFFIXES
option (already available in CMake 3.5 https://cmake.org/cmake/help/v3.5/command/find_path.html, minimum required version for this package). In theory we could remove the other arguments passed toPATHS
, but as they do not hurt and leaving them minimize the risk of regressions, I think we can leave them.A similar fix done in g2o: RainerKuemmerle/g2o@4f092a4 .
Description of documentation updates required from your changes
Future work that may be required in bullet points