feat: Adds a message logging function #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/review |
ghost
reviewed
Feb 28, 2023
| @@ -19,3 +19,13 @@ def convert_fahrenheit_to_celsius(input_temperatures: List[float]) -> List[float | |||
| """ | |||
|
|
|||
| return [(fahrenheit_temp - 32) * 5 / 9 for fahrenheit_temp in input_temperatures] | |||
|
|
|||
|
|
|||
| def log_message(message): | |||
There was a problem hiding this comment.
Would you mind adding type annotations? 🙏
Pattern explanation 👈
In Python, type annotations are not enforced. But that can be valuable for debugging using mypy, and for your collaborators' understanding. Check here for reference.Replacement example
Here is an example of how you could handle this:
def is_upper(variable_name: str) -> bool:This comment is about [missing-type-annotations]. Add the following reactions on this comment to let us know if:
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear
| Args: | ||
| message: a string | ||
| """ | ||
| import logging |
There was a problem hiding this comment.
Imports are expected to be at the top of the module
Pattern explanation 👈
Just like any other statements, imports require a given amount of time to be executed. However, because they aren't dynamic (you always import the same module, it's not an input of your program), you can avoid performing the import more times than necessary by placing them at the top of the module. Check here for reference.This comment is about [late-import]. Add the following reactions on this comment to let us know if:
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uie,