Fix code scanning alert no. 1: Prototype-polluting function #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
alex-w
added
the
state: published
|
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @alex-w! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Stellarium/stellarium/security/code-scanning/1
To fix the prototype pollution vulnerability in the
extendfunction, we need to add checks to prevent the merging of special properties like__proto__andconstructor. This can be done by adding a condition to skip these properties during the merge process.__proto__andconstructorduring the merge process.extendfunction to include a check that skips the properties__proto__andconstructorwhen copying properties from the source object to the target object.extendfunction in the fileplugins/RemoteControl/webroot/js/globalize.jsto include the necessary checks.extendfunction.Suggested fixes powered by Copilot Autofix. Review carefully before merging.