Fix orientation of sensor rectangle in equatorial mode #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we get rid of the concept of polar angle inside Oculars::paintCCDBounds(), instead the correct orientation is automatically defined by the projector corresponding to the mount of the current telescope.
|
The orientation is fixed, but the text in corners has density issue now on HiDPI devices
|
Well, this is a separate problem orthogonal to this PR. |
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we get rid of the concept of polar angle inside Oculars::paintCCDBounds(), instead the correct orientation is automatically defined by the projector corresponding to the mount of the current telescope.
This should fix the wrong orientation of the rectangle in equatorial mode. Please check that it works in all relevant modes (some of which I might be unaware of).