Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery of DSO #3084

Merged
merged 6 commits into from
Mar 6, 2023
Merged

Discovery of DSO #3084

merged 6 commits into from
Mar 6, 2023

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Mar 6, 2023

Description

Added support for the info for year of discovery and name of discoverer for Messier catalog. I am able to add similar data for objects from NGC/IC catalogs also, but these data should be as 2 extra columns for the 4th version of the main DSO catalog.

The discovery info was needed for me when I gave a lecture about the Messier catalog for a club of amateur astronomers in the local planetarium.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111 and gzotti March 6, 2023 15:16
@alex-w alex-w added this to the 23.1 milestone Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w
Copy link
Member Author

alex-w commented Mar 6, 2023

@gzotti OK, done! Thanks for suggestions.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I like historical data!

@alex-w alex-w merged commit b4a5cac into master Mar 6, 2023
@alex-w alex-w deleted the dso/discovery branch March 6, 2023 16:42
@github-actions
Copy link

Hello @alex-w!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@github-actions
Copy link

Hello @alex-w!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Mar 13, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants