Rename vectors methods length and lengthSquared into norm and normSquared #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
10110111
force-pushed
the
master
branch
2 times, most recently
from
e95a5df to
670ba7d
Compare
…ared When porting C++ code to GLSL the length() method can lead to hard to diagnose bugs, because this method in GLSL returns number of elements of a vector, while we supposed to get the norm of the vector. This patch renames the length() method of all VecMath's vectors, and for consistency also lengthSquared(), to say norm instead of length. The old names are explicitly marked as deleted so that those who write new code don't get surprised by unavailability of these functions.
gzotti
approved these changes
Oct 31, 2022
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting C++ code to GLSL the length() method can lead to hard to diagnose bugs (and I have been bitten by this), because this method in GLSL returns number of elements of a vector, while we supposed to get the norm of the vector. This patch renames the length() method of all VecMath's vectors, and for consistency also lengthSquared(), to say norm instead of length.
The old names are explicitly marked as deleted so that those who write new code don't get surprised by unavailability of these functions.