Fix a bug with dynamic plugins loading #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The export of symbols from the executables was disabled with cmake 3.4. This was preventing the loading of dynamic plugins in stellarium. see https://cmake.org/cmake/help/v3.4/policy/CMP0065.html
alex-w
added
the
state: published
|
Hello @gui-co! Please check the fresh version (development snapshot) of Stellarium: |
|
Happy to contribute. |
alex-w
removed
the
state: published
|
Hello @gui-co! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR fixes an issue that prevents the loading of dynamic plugins into Stellarium.
Description
With the introduction of CMP0065 in cmake 3.4, the symbols are not automatically exported for executables. When a dynamic plugin is loaded into Stellarium, an
undefined symbolerror occurs.The
ENABLE_EXPORTSproperty has been set for the executable.Type of change
How Has This Been Tested?
To test, one can build and install the StellariumPluginTemplate. On
master, this should give anundefined symbol: _ZN10StelModule16staticMetaObjectE)error when Stellarium tries to load the plugin. On this PR, the plugin is properly loaded.Test Configuration:
Checklist: