Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skyculture greek_leidenAratea : When search "Pleiades", dark screen was shown. #3931

Open
3domennotry opened this issue Oct 3, 2024 · 2 comments
Assignees
Labels
data Missing/bad/outdated data, but no code error purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes subsystem: skycultures The issue is related to skycultures of planetarium...
Milestone

Comments

@3domennotry
Copy link

Expected Behaviour

Actual Behaviour

Steps to reproduce

  1. select skyculture greek_leidenAratea
  2. open Search window
  3. input "Pleiades" and enter
    20241003_1-1
    20241003_1-2

I think that There is a problem with the file "constellationship.fab".
Line 51
M45 0 1165

by the way

(install_dir)/skycultures/greek_leidenAratea/

constellation_names.eng.fab
Line 2
Line 37

description.en.utf8
Line 6
Line 27
Line 220

Ursa Ma"i"or and Canis Ma"i"or
Is this correct? Latin spelling?


System

  • Stellarium version: stellarium-24.3-qt5-win32.exe

  • Operating system: Win7 32bit

(Sorry, I can not speak English very well.)

thank you.

@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Oct 3, 2024
@gzotti
Copy link
Member

gzotti commented Oct 3, 2024

Ursa Ma"i"or and Canis Ma"i"or
Is this correct? Latin spelling?

yes. There was no separate J in the Latin alphabet.

@alex-w
Copy link
Member

alex-w commented Oct 4, 2024

I think that There is a problem with the file "constellationship.fab".
Line 51
M45 0 1165

Yes. 1165 is designation of the star in HR catalog, but we use HIP designations for constellation's attachments. I've fixed this typo + definition of this constellation (the constellation should have minimum 1 segment). See revision a47099b

P.S. In any way the skyculture already has DSO M45/Pleiades, maybe we should remove the constellation with same name? @sushoff

@alex-w alex-w added this to the 24.4 milestone Oct 4, 2024
@alex-w alex-w self-assigned this Oct 4, 2024
@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Oct 13, 2024
@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
@alex-w alex-w modified the milestones: 24.4, 25.1 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes subsystem: skycultures The issue is related to skycultures of planetarium...
Development

No branches or pull requests

4 participants