Plugin Scenery3d - windows 11 - Qt 6.7.1 - APIENTRYP

[uwes-ufo]

stellarium/plugins/Scenery3d/src/GLFuncs.hpp

Line 37 in 45afd56

void (APIENTRYP glDrawBuffer)(GLenum);

Somehow APIENTRYP is not defined.
As a cheap workaround I added:

 #include <QOpenGLContext>
 #include <QOpenGLFunctions_1_0>
 
+#if defined(_WIN32)
+#include <qt_windows.h>
+#endif
+
 #if !QT_CONFIG(opengles2)
 //! Defines some OpenGL functions not resolved through StelOpenGL (which only contains base OpenGL ES2 functions)

But honestly I don't have enough background knowledge to provide a real solution.

[gzotti]

I don't understand. Does compilation suddenly fail on your system? I think Qt6.7.1 is the latest release, right? Maybe a Qt issue then? Or is including qt_windows.h a new requirement with Qt6.7?

[uwes-ufo]

Yes, compilation fails with Qt 6.7.x, but Qt 6.6.x works.

[10110111]

What if you replace APIENTRYP with QOPENGLF_APIENTRYP?

[gzotti]

OK, then the first guard is also test on Qt version>=6.7 before this inclusion. Then we should see why this file is now required, i.e., what changed in Qt , and whether Qt has released some statement about it.

[10110111]

Or maybe, instead of replacing this with a Qt-specific macro, just try including <qopengl.h>.

[uwes-ufo]

QOPENGLF_APIENTRYP works!
Thank you!

(no luck with <qopengl.h>)

[alex-w]

QOPENGLF_APIENTRYP works! Thank you!

(no luck with <qopengl.h>)

What about QOPENGLF_APIENTRYP with Qt 6.6?

[gzotti]

I would still enclose this by a Qt version test. Or confirm it's OK with Qt5.12 as well.

[10110111]

We can just push it into a branch and let the CI sort it out.

[uwes-ufo]

At least it passed some tests.
uwes-ufo/stellarium

[10110111]

At least it passed some tests.
uwes-ufo/stellarium

I don't find AppVeyor ones there... You may have to connect an AppVeyor account to make them work. Or I can push it myself if you fail.

[uwes-ufo]

Yes, please do another test because my fork is a bit different.

[10110111]

Let's see if this build works out, and on success I'll push this commit to master.

[github-actions]

Hello @uwes-ufo!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @uwes-ufo!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest