Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer's bug: Wrong version number #2728

Closed
chardoncs opened this issue Oct 6, 2022 · 3 comments
Closed

Installer's bug: Wrong version number #2728

chardoncs opened this issue Oct 6, 2022 · 3 comments
Labels
not a bug This is not a bug, it's a feature

Comments

@chardoncs
Copy link

chardoncs commented Oct 6, 2022 •
edited
Loading

Expected Behaviour

Displaying "1.0" or "1.0.0"

Actual Behaviour

Displaying "1.22.3"

image

System

  • Stellarium version: 1.0
  • Operating system: Windows 11
@alex-w
Copy link
Member

alex-w commented Oct 6, 2022 •
edited
Loading

This is correct inner version number, please see Stellarium User Guide for details.

P.S. But you are partially right - the variable AppVerName should contain public version (e.g. Stellarium 1.0)

@alex-w alex-w added the not a bug This is not a bug, it's a feature label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This is not a bug! This is a feature...

@github-actions github-actions bot closed this as completed Oct 6, 2022
alex-w added a commit that referenced this issue Oct 6, 2022
@alex-w
Cosmetic fix for Windows installer (see #2728)
6343b93 
Let's use public version for AppVerName variable
@chardoncs
Copy link
Author

This is correct inner version number, please see Stellarium User Guide for details.

I see. Sorry for that...😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not a bug This is not a bug, it's a feature
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-w @chardoncs