-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug if we set isVisible default: true #23
Comments
Equivalent to #14, right? |
Please describe specifically what you are seeing (what is the bug?), some code snippets, and versions of react-native-popover-view and device versions so that I can replicate. |
Yes. It seems like #14. |
Is it working for you now? The popover should show immediately when |
It's not working. I have to set "true" in componentDidMount but sometime it's didn't work. |
Ok, I currently have a pretty bare-bones app that has this working, so it's probably something with your setup. Can you post a sample of the code so that I can try it out? |
This is my code. The popover show but if I reload simulator the position of popover will be changed.
And code of component AppBackground
|
My problem are in AppBackground and any screens have navigation. If I don't use it, the popover will work well. Do you know how I can solve it ? |
Does the issue go away if you don’t wrap the Popover in AppBackground? |
I’ve never witnessed a situation where the initial load yields a different resulting DOM from subsequent reloads, if you have the capability to record a short video of what is happening and upload that, it would be useful for anlayzing the situation. Also, if you upgrade react-native-popover-view to the latest version and use the |
This is a video of bug. The debug console. ( it's always change )
"react-native-popover-view": "version": "1.0.10", |
The issue go away if I remove the AppBackground. The AppBackground is a view that cover all component when render so it must be used in my code ( you can see code AppBackground). |
Ohhhh, that video helps so much! I have seen this issue before, give me a few minutes to see if I can remember what caused it. |
Ok, published 1.0.11, no idea if this will actually fix your issues but it may. |
it's still not working @SteffeyDev. It always change position of popover. |
Video version 1.0.11 |
Ok, is it possible you could grab the full debug output when it does the crazy change size thing? That would help me understand what is going on. |
I added a debug statement in 1.0.11 that may help |
The console always update so I will copy a part of it for you.
|
Ok, I am more hopeful about version 1.0.12, whenever you have the chance to try it out. |
It's still some small bugs. Popover had move a little bit when it show on screen sometime the arrow move too.
|
Oh no. |
Ok, 1.0.13 should fix the issue on iOS with it moving slightly after launch. I can't replicate the issue on Android, can you provide video and logs again? Or even just logs would help. |
Bug on IOS:
|
Bug on android.
|
Ok, so the "bug" on iOS is actually something you need too fix on your end, you can see in the logs that the To fix this, you need to delay setting I'll look into the Android issue next. |
For Android, it looks like it can't find the dimensions of the
Note: you will have to import If |
If my hunch is correct, fixing the issue on iOS may actually fix the Android issue as well, so try that first. |
IOS is working.
|
So you are saying that |
Check out this issue, it seems similar to your situation (valid on iOS but undefined on Android): facebook/react-native#12966 |
This's result you need. |
Ok, so I believe the issue is once again on your side, and it is that when the Popover is initially rendered, the |
@huynguyen2903 were you able to solve? |
This should help clarify a few things that we learned in those issues
Closing due to inactivity, open a new issue if this issue reappears. |
If I want to open Popover when start the screen so I set isVisible: “true” and it have a bug.
Can you help me fix it ?
Many thanks.
The text was updated successfully, but these errors were encountered: