corner case fixed: task should run again after test file was modified #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see GradleRunner.withDebug(boolean flag)
instead of hardcoded string
this one:
As part of making the publishing plugins stable, the 'deferred
configurable' behavior of the 'publishing {}' block has been deprecated.
In Gradle 5.0 the 'enableFeaturePreview('STABLE_PUBLISHING')' flag will
be removed and the new behavior will become the default. Please add
'enableFeaturePreview('STABLE_PUBLISHING')' to your settings file and do
test run by publishing to a local repository. If all artifacts are
published as expected, there is nothing else to do. If the published
artifacts change unexpectedly, please see the migration guide for more
details:
https://docs.gradle.org/4.10.2/userguide/publishing_maven.html#publishing_maven:deferred_configuration.
`task should run again after test file was modified`
also remove intermediate input task so dump input file summary to FS is now avoided
guru.stefma.gloc -> kotlin2ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found your presentation at Droidconf and was deeply impressed by TTD approach you undertook. This is a way that any new gradle plugin should be created. So I chose your project as a base for my kotlin2typescript gradle plugin.
Meanwhile, I think I've found a corner case for the current LOC plugin. Assert that task should run again after test file was modified if failing for now. I'd like to provide refactored plugin that fixes the issue. I did that just for fun and hope you'll have it too reviewing my pull request.