Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_deref broken on Mac #57

Closed
tcmulcahy opened this issue Apr 15, 2024 · 1 comment · Fixed by bytecodealliance/rustix#1045 or #59
Closed

get_deref broken on Mac #57

tcmulcahy opened this issue Apr 15, 2024 · 1 comment · Fixed by bytecodealliance/rustix#1045 or #59

Comments

@tcmulcahy
Copy link
Contributor

@notgull the fix for get - bytecodealliance/rustix@10361e7 - also needs to be applied to get_deref.

The easiest way to repro is to change the xattr::get to xattr::get_deref in https://github.com/Stebalien/xattr/blob/master/tests/main.rs#L60

Test output:

---- test_path stdout ----
thread 'test_path' panicked at tests/main.rs:60:51:
called `Result::unwrap()` on an `Err` value: Os { code: 34, kind: Uncategorized, message: "Result too large" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@Stebalien
Copy link
Owner

@tcmulcahy upstream fix is here: bytecodealliance/rustix#1045. Could you make a PR (here) with a failing regression test?

sunfishcode pushed a commit to bytecodealliance/rustix that referenced this issue Apr 15, 2024
Stebalien added a commit that referenced this issue May 10, 2024
Stebalien added a commit that referenced this issue May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants