Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nethook to protobuf-2.6.1 #965

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Update nethook to protobuf-2.6.1 #965

merged 1 commit into from
Mar 22, 2021

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 17, 2021

That's what Steam uses now. I haven't built locally, want to see if actions succeeds.

@yaakov-h
Copy link
Member

yaakov-h commented Mar 17, 2021

  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "void __cdecl google::protobuf::internal::InitEmptyString(void)" (?InitEmptyString@internal@protobuf@google@@YAXXZ) referenced in function "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __cdecl google::protobuf::internal::GetEmptyString(void)" (?GetEmptyString@internal@protobuf@google@@YAABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "public: static unsigned char * __cdecl google::protobuf::io::CodedOutputStream::WriteStringWithSizeToArray(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,unsigned char *)" (?WriteStringWithSizeToArray@CodedOutputStream@io@protobuf@google@@SAPAEABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PAE@Z) referenced in function "public: static unsigned char * __cdecl google::protobuf::internal::WireFormatLite::WriteBytesToArray(int,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,unsigned char *)" (?WriteBytesToArray@WireFormatLite@internal@protobuf@google@@SAPAEHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PAE@Z) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "public: static void __cdecl google::protobuf::internal::WireFormatLite::WriteStringMaybeAliased(int,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class google::protobuf::io::CodedOutputStream *)" (?WriteStringMaybeAliased@WireFormatLite@internal@protobuf@google@@SAXHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PAVCodedOutputStream@io@34@@Z) referenced in function "public: virtual void __thiscall CBilling_Address::SerializeWithCachedSizes(class google::protobuf::io::CodedOutputStream *)const " (?SerializeWithCachedSizes@CBilling_Address@@UBEXPAVCodedOutputStream@io@protobuf@google@@@Z) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "public: static void __cdecl google::protobuf::internal::WireFormatLite::WriteBytesMaybeAliased(int,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class google::protobuf::io::CodedOutputStream *)" (?WriteBytesMaybeAliased@WireFormatLite@internal@protobuf@google@@SAXHABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PAVCodedOutputStream@io@34@@Z) referenced in function "public: virtual void __thiscall CMsgAuthTicket::SerializeWithCachedSizes(class google::protobuf::io::CodedOutputStream *)const " (?SerializeWithCachedSizes@CMsgAuthTicket@@UBEXPAVCodedOutputStream@io@protobuf@google@@@Z) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "public: __thiscall google::protobuf::internal::GeneratedMessageReflection::GeneratedMessageReflection(class google::protobuf::Descriptor const *,class google::protobuf::Message const *,int const * const,int,int,int,void const *,int,class google::protobuf::DescriptorPool const *,class google::protobuf::MessageFactory *,int)" (??0GeneratedMessageReflection@internal@protobuf@google@@QAE@PBVDescriptor@23@PBVMessage@23@QBHHHHPBXHPBVDescriptorPool@23@PAVMessageFactory@23@H@Z) referenced in function "void __cdecl protobuf_AssignDesc_steammessages_5fbase_2eproto(void)" (?protobuf_AssignDesc_steammessages_5fbase_2eproto@@YAXXZ) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2019: unresolved external symbol "private: static void __cdecl google::protobuf::internal::WireFormat::VerifyUTF8StringFallback(char const *,int,enum google::protobuf::internal::WireFormat::Operation,char const *)" (?VerifyUTF8StringFallback@WireFormat@internal@protobuf@google@@CAXPBDHW4Operation@1234@0@Z) referenced in function "public: static void __cdecl google::protobuf::internal::WireFormat::VerifyUTF8StringNamedField(char const *,int,enum google::protobuf::internal::WireFormat::Operation,char const *)" (?VerifyUTF8StringNamedField@WireFormat@internal@protobuf@google@@SAXPBDHW4Operation@1234@0@Z) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2001: unresolved external symbol "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const * const google::protobuf::internal::empty_string_" (?empty_string_@internal@protobuf@google@@3PBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  steammessages_base.pb.obj : error LNK2001: unresolved external symbol "int google::protobuf::internal::empty_string_once_init_" (?empty_string_once_init_@internal@protobuf@google@@3HA) [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]
  D:\a\SteamKit\SteamKit\Resources\NetHook2\Debug\NetHook2.dll : fatal error LNK1120: 8 unresolved externals [D:\a\SteamKit\SteamKit\Resources\NetHook2\NetHook2\NetHook2.vcxproj]

@xPaw
Copy link
Member Author

xPaw commented Mar 18, 2021

Yep.

There is detours.lib, libprotobuf.lib, libprotobuf_r.lib, zlib.lib in the repo. Setting up dependencies doesn't actually build these.

These files add up to like 44mb in the repo. I don't know how to fix it so it builds from the pulled source instead of keeping these libs in the repo.

@yaakov-h yaakov-h merged commit 64fc15e into SteamRE:master Mar 22, 2021
@xPaw xPaw deleted the proto branch March 22, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants