Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Max value from enums and update some #849

Merged
merged 5 commits into from
May 16, 2020
Merged

Remove Max value from enums and update some #849

merged 5 commits into from
May 16, 2020

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 14, 2020 •
edited
Loading

No description provided.

@yaakov-h yaakov-h linked an issue May 15, 2020 that may be closed by this pull request
Are "Max" values necessary in enums #571
Closed
@yaakov-h yaakov-h mentioned this pull request May 15, 2020
Closed
@yaakov-h
Copy link
Member 

Build FAILED.
Types\SteamID.cs(462,99): error CS0117: 'EAccountType' does not contain a definition for 'Max' [C:\projects\steamkit\SteamKit2\SteamKit2\SteamKit2.csproj]
Types\SteamID.cs(465,101): error CS0117: 'EUniverse' does not contain a definition for 'Max' [C:\projects\steamkit\SteamKit2\SteamKit2\SteamKit2.csproj]
    0 Warning(s)
    2 Error(s)
Time Elapsed 00:00:27.28

😢

@yaakov-h yaakov-h merged commit 9d42533 into SteamRE:master May 16, 2020
@xPaw xPaw deleted the fix-571 branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustArchi JustArchi JustArchi left review comments

@yaakov-h yaakov-h yaakov-h left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are "Max" values necessary in enums
3 participants
@xPaw @yaakov-h @JustArchi