Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DepotManifest constructor public #841

Merged
merged 1 commit into from
May 6, 2020
Merged

Make DepotManifest constructor public #841

merged 1 commit into from
May 6, 2020

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 6, 2020

Fixes #840

I successfuly used it in https://github.com/xPaw/SteamDepotFileVerifier by using reflection.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #841 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   22.75%   22.75%   -0.01%     
==========================================
  Files          95       95              
  Lines        9343     9344       +1     
  Branches      780      780              
==========================================
  Hits         2126     2126              
- Misses       7083     7084       +1     
  Partials      134      134              
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Types/DepotManifest.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007393c...60f29ae. Read the comment docs.

@yaakov-h
Copy link
Member

yaakov-h commented May 6, 2020

You can probably simplify your “dumb” hack with Activator.CreateInstance.

Id actually rather make this a static method. I’m pretty firmly in the “constructors should do no work” camp and boy is this one doing a lot of work.

@azuisleet azuisleet merged commit 9e9c82e into SteamRE:master May 6, 2020
@xPaw xPaw deleted the depotmanifest-constructor branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DepotManifest constructor public
3 participants