-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobufs #827
Update protobufs #827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
==========================================
+ Coverage 22.75% 22.89% +0.13%
==========================================
Files 95 95
Lines 9344 9283 -61
Branches 780 779 -1
==========================================
- Hits 2126 2125 -1
+ Misses 7084 7024 -60
Partials 134 134
Continue to review full report at Codecov.
|
I think this makes sense, but wouldn't mind a second opinion. What changes need to be made for Underlords? |
Needs to bring in a bunch of more proto files like user messages, can't be bothered to deal with it. |
Most of this looks good to me as well - I think I originally suggested merging the internal namespaces on IRC. They're internal anywhere so the implication is that breakage here from time to time is expected. I could go either way on |
An obsolete stub could just cause consumers to leak resources, waiting for an event that never fires. Throwing an exception sounds good, but removing the method will also cause an exception to be thrown... just far more cryptically. I think all-up I'd rather keep the method, make it throw an exception, mark as obsolete and optionally hide it with |
Anything blocking this? There are proto updates that I'd like to use. |
EnumeratePublishedFiles
because all the protos for it are gone; can't obsolete it becauseCMsgCREEnumeratePublishedFilesResponse
was removed and it won't compile.SteamKit2.Unified.Internal
toSteamKit2.Internal
because some protos depend on each other and they're in separate namespaces.If this change is not acceptable, then protobuf generation needs to be upgraded to allow adding usings.