Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AyncJob support for GetLobbyListCallback #825

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

Benjamin-Dobell
Copy link
Contributor

@Benjamin-Dobell Benjamin-Dobell commented Mar 31, 2020

Closes #824

Copy link
Contributor

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #825 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   22.77%   22.77%   -0.01%     
==========================================
  Files          95       95              
  Lines        9329     9331       +2     
  Branches      772      772              
==========================================
  Hits         2125     2125              
- Misses       7070     7072       +2     
  Partials      134      134              
Impacted Files Coverage Δ
...mKit2/Steam/Handlers/SteamMatchmaking/Callbacks.cs 0.00% <0.00%> (ø)
...team/Handlers/SteamMatchmaking/SteamMatchmaking.cs 3.76% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a200f...39f8417. Read the comment docs.

@azuisleet azuisleet merged commit 75cfb95 into SteamRE:master Mar 31, 2020
@Tyaap
Copy link

Tyaap commented Mar 31, 2020

Thank you for fixing this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncJob from GetLobbyList always times out.
4 participants