Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CMsgIPAddress #770

Merged
merged 6 commits into from
May 14, 2020
Merged

Implement CMsgIPAddress #770

merged 6 commits into from
May 14, 2020

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Oct 30, 2019

  • Obfuscation for ipv6 is implemented
  • NetHelpers.TryParseIPEndPoint doesn't support IPv6 bracket notation
  • LoginID in logon just sets v4 - i don't think this a big of an issue
  • CMsgGSServerType has deprecated_game_ip_address, but there are no other fields for IP

I can't test any of this because there's no way of getting ipv6 cm servers anywhere yet.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #770 into master will increase coverage by 0.18%.
The diff coverage is 44.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   22.89%   23.07%   +0.18%     
==========================================
  Files          95       95              
  Lines        9283     9368      +85     
  Branches      779      784       +5     
==========================================
+ Hits         2125     2162      +37     
- Misses       7024     7071      +47     
- Partials      134      135       +1     
Impacted Files Coverage Δ
.../Steam/Handlers/SteamGameServer/SteamGameServer.cs 18.81% <0.00%> (+0.36%) ⬆️
...Kit2/Steam/Handlers/SteamMasterServer/Callbacks.cs 0.00% <0.00%> (ø)
...am/Handlers/SteamMasterServer/SteamMasterServer.cs 15.90% <0.00%> (ø)
...team/Handlers/SteamMatchmaking/SteamMatchmaking.cs 3.77% <0.00%> (ø)
...t2/SteamKit2/Steam/Handlers/SteamUser/Callbacks.cs 2.89% <0.00%> (+0.11%) ⬆️
...t2/SteamKit2/Steam/Handlers/SteamUser/SteamUser.cs 25.30% <0.00%> (-0.10%) ⬇️
SteamKit2/SteamKit2/Util/Utils.cs 38.80% <57.77%> (+13.80%) ⬆️
...Kit2/Steam/Handlers/SteamWorkshop/SteamWorkshop.cs 9.34% <0.00%> (-2.99%) ⬇️
SteamKit2/SteamKit2/Types/DepotManifest.cs 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3c65a...31618cc. Read the comment docs.

@xPaw xPaw marked this pull request as ready for review November 4, 2019 11:32
SteamKit2/SteamKit2/Util/Utils.cs Outdated Show resolved Hide resolved
SteamKit2/SteamKit2/Util/Utils.cs Show resolved Hide resolved
SteamKit2/SteamKit2/Util/Utils.cs Outdated Show resolved Hide resolved
@yaakov-h
Copy link
Member

My guess on CMsgGSServerType is that they're implementing IPv6 Steam infrastructure before implementing IPv6 game server support.

@xPaw
Copy link
Member Author

xPaw commented Apr 18, 2020

I added method extensions onto CMsgIPAddress, didn't do it on IPAddress.

Copy link
Member

@yaakov-h yaakov-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sold on the RollForward but I think the v6 stuff looks right now.

Copy link
Member

@yaakov-h yaakov-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NullReferenceException in the extension method because public_ip is null.

image

@yaakov-h yaakov-h merged commit e655d5b into SteamRE:master May 14, 2020
@xPaw xPaw deleted the CMsgIPAddress branch May 14, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants