-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CMsgIPAddress #770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 22.89% 23.07% +0.18%
==========================================
Files 95 95
Lines 9283 9368 +85
Branches 779 784 +5
==========================================
+ Hits 2125 2162 +37
- Misses 7024 7071 +47
- Partials 134 135 +1
Continue to review full report at Codecov.
|
My guess on |
I added method extensions onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sold on the RollForward but I think the v6 stuff looks right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NetHelpers.TryParseIPEndPoint
doesn't support IPv6 bracket notationLoginID
in logon just sets v4 - i don't think this a big of an issueCMsgGSServerType
hasdeprecated_game_ip_address
, but there are no other fields for IPI can't test any of this because there's no way of getting ipv6 cm servers anywhere yet.