Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EPurchaseResultDetail #729

Merged
merged 3 commits into from
Nov 3, 2019
Merged

Conversation

yaakov-h
Copy link
Member

@yaakov-h yaakov-h commented Oct 3, 2019

Resolves #523, finally.

I gave up and added my own names since Valve's dont seem to appear anywhere that we can get our hands on.

@yaakov-h yaakov-h added this to the 2.3.0 milestone Oct 3, 2019
@xPaw
Copy link
Member

xPaw commented Oct 3, 2019

This should be all the values starting from 67:

67 "Complete-the-set bundles cannot be gifted"
68 "Blocked by U.S. government regulations"
69 "Blocked because user is not a commercial partner"
70 "The gift recipient already owns the gift"
71 "The gift is not valid for the recipient's region"
72 "The gift's price is significantly higher in the recipient's region, so the purchase is blocked"
73 "No account or email was specified to send the gift"
74 "Business account not allowed to purchase"
75 "Store / Business country code mismatch"
76 "User is associated with multiple cafes"
77 "User is not associated with any cafes"
78 "Address is invalid or contains invalid characters"
79 "Credit card number is invalid (does not pass LUHN checksum)"
80 "Cannot ship to APO/FPO"
81 "Billing name is invalid because it looks like it contains credit card data"
82 "Payment method is disabled"
83 "Payment method is not allowed for this purchase"

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #729 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage    22.5%   22.74%   +0.24%     
==========================================
  Files          94       94              
  Lines        9630     9306     -324     
  Branches      814      770      -44     
==========================================
- Hits         2167     2117      -50     
+ Misses       7329     7055     -274     
  Partials      134      134
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Base/PacketBase.cs 55.55% <0%> (-11.12%) ⬇️
SteamKit2/SteamKit2/Base/ClientMsg.cs 22.98% <0%> (-9.78%) ⬇️
SteamKit2/SteamKit2/Util/Utils.cs 25% <0%> (-3.05%) ⬇️
SteamKit2/SteamKit2/Util/HardwareUtils.cs 25.35% <0%> (-1.88%) ⬇️
SteamKit2/SteamKit2/Util/DebugNetworkListener.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Steam/SteamClient/Callbacks.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Steam/UFSClient/UFSClient.cs
SteamKit2/SteamKit2/Steam/UFSClient/Callbacks.cs
.../Steam/Handlers/SteamNetworking/SteamNetworking.cs 21.21% <0%> (ø)
...amKit2/Steam/Handlers/SteamNetworking/Callbacks.cs 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f9a5b...3a7accd. Read the comment docs.

@yaakov-h yaakov-h merged commit 8fb6ba8 into SteamRE:master Nov 3, 2019
@yaakov-h yaakov-h deleted the purchaseresult branch November 3, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated protobufs
2 participants