Throw an exception if chunk length mismatches #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voided
requested changes
Feb 1, 2019
There was a problem hiding this comment.
Change looks good to me (and also has @azuisleet's blessing).
Only thing I'd suggest is documenting this new exception in the xmldocs.
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
=========================================
+ Coverage 23.6% 23.6% +<.01%
=========================================
Files 85 85
Lines 8714 8713 -1
Branches 719 719
=========================================
Hits 2057 2057
+ Misses 6526 6525 -1
Partials 131 131
Continue to review full report at Codecov.
|
voided
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes chunk downloading throws "The input data is not a complete block." and I think this check should prevent that.