Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NetworkInformationException #630

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Fix for NetworkInformationException #630

merged 3 commits into from
Jan 22, 2019

Conversation

felipe19930
Copy link
Contributor

Fixes #629

Copy link
Contributor

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks good enough and fixes the issue, I also don't see any drawbacks to accepting it. Any potential improvements to the underlying SK2 logic should be done in separate PRs, if somebody will come up with a better solution considering newly-discovered details, of course.

@yaakov-h
Copy link
Member

This catches a documented exception.

👍

SteamKit2/SteamKit2/Util/HardwareUtils.cs Outdated Show resolved Hide resolved
SteamKit2/SteamKit2/Util/HardwareUtils.cs Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #630 into master will increase coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #630      +/-   ##
=========================================
+ Coverage   23.59%   23.6%   +0.01%     
=========================================
  Files          85      85              
  Lines        8709    8713       +4     
  Branches      719     719              
=========================================
+ Hits         2055    2057       +2     
- Misses       6523    6525       +2     
  Partials      131     131
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Util/HardwareUtils.cs 25.96% <60%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec01c92...16218bf. Read the comment docs.

@yaakov-h yaakov-h merged commit c607d39 into SteamRE:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants