Fix cm0.steampowered.com port #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't listen on 27015.
|
It looks like Steam has gone back to having a hardcoded list. cm0 appears to be listening on 27017, 27018 and 27019 for Valve TCP, and 27020 and 27021 for TLS. Should we copy Steam's hardcoded list, or branch off into our own thing (like this PR)? cc/ @azuisleet @voided
|
|
@yaakov-h I see no reason to hardcode the list, just fix the port and be done with it :) |
|
This is OK to merge. I don't know if we want to hard code the server list at this point, since SteamDirectory really should be the source. If there are connectivity issues, ideally you would have configured a persistent store for the server list. |
|
What if there are connectivity issues during the first run? |
|
That wouldn't be much different than not being able to reach Steam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't listen on 27015.