Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EMsg and some enums #569

Merged
merged 1 commit into from
Jul 8, 2018
Merged

Update EMsg and some enums #569

merged 1 commit into from
Jul 8, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jun 28, 2018

No description provided.

@yaakov-h
Copy link
Member

What's the source on these?

If you got the EMsgs from Steam, please also update emsg_list_detailed.txt.

@xPaw
Copy link
Member Author

xPaw commented Jun 28, 2018

nethook for emsg, and steamdb tracker for enums

@codecov-io
Copy link

codecov-io commented Jun 28, 2018 •
edited
Loading

Codecov Report

Merging #569 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   22.12%   22.12%           
=======================================
  Files          86       86           
  Lines        8666     8666           
  Branches      714      714           
=======================================
  Hits         1917     1917           
  Misses       6624     6624           
  Partials      125      125
Impacted Files Coverage Δ
...amKit2/Steam/Handlers/SteamFriends/SteamFriends.cs 5.03% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497e84e...f67fc73. Read the comment docs.

yaakov-h
yaakov-h reviewed Jun 28, 2018
View reviewed changes
Resources/Misc/emsg_list_detailed.txt
k_EMsgClientFSGetFriendMessageHistory = 7525, // flags: 6, server type: 47
k_EMsgClientFSGetFriendMessageHistoryResponse = 7526, // flags: 6, server type: 47
k_EMsgClientFSGetFriendMessageHistoryForOfflineMessages = 7527, // flags: 6, server type: 47
k_EMsgClientChatOfflineMessageNotification = 7523, // flags: 2, server type: -1
Copy link
Member

@yaakov-h yaakov-h Jun 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should have corresponding EMsg updates... we usually leave the old name in as an obsoleted alias for one release.

@xPaw
Copy link
Member Author

xPaw commented Jul 7, 2018

@yaakov-h Done, I think?

yaakov-h
yaakov-h reviewed Jul 7, 2018
View reviewed changes
Resources/SteamLanguage/emsg.steamd Outdated
ClientFSRequestOfflineMessageCount = 7524; removed "Renamed to ClientChatRequestOfflineMessageCount"
ClientFSGetFriendMessageHistory = 7525; removed "Renamed to ClientChatGetFriendMessageHistory"
ClientFSGetFriendMessageHistoryResponse = 7526; removed "Renamed to ClientChatGetFriendMessageHistoryResponse"
ClientFSGetFriendMessageHistoryForOfflineMessages = 7527; removed "Renamed to ClientChatGetFriendMessageHistoryForOfflineMessages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use obsolete instead of removed to continue generating the C# code for this enum value.

@xPaw
Copy link
Member Author

xPaw commented Jul 8, 2018

Dooooooooone

@yaakov-h yaakov-h merged commit 730482b into SteamRE:master Jul 8, 2018
@xPaw xPaw deleted the xpaw/emsg branch July 8, 2018 13:54
This was referenced Aug 5, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakov-h yaakov-h yaakov-h left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @yaakov-h @codecov-io