Simplify info in nethook analyzer #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustArchi
approved these changes
Oct 14, 2021
yaakov-h
approved these changes
Oct 18, 2021
Resources/NetHookAnalyzer2/NetHookAnalyzer2/NetHookItemTreeBuilder.cs
Outdated
Show resolved
Hide resolved
Resources/NetHookAnalyzer2/NetHookAnalyzer2/NetHookItemTreeBuilder.cs
Outdated
Show resolved
Hide resolved
|
What was the problem with making it the root node? |
|
I tried to make TreeNode and similar things, but it would either render only the text or the message data, but not both, which is quite strange. |
Co-authored-by: Yaakov <[email protected]>
|
Actually got it to work.
|
yaakov-h
approved these changes
Oct 24, 2021
| @@ -300,6 +300,7 @@ private void InitializeComponent() | |||
| this.itemExplorerTreeView.Name = "itemExplorerTreeView"; | |||
| this.itemExplorerTreeView.Size = new System.Drawing.Size(455, 426); | |||
| this.itemExplorerTreeView.TabIndex = 0; | |||
| this.itemExplorerTreeView.ShowRootLines = false; | |||
There was a problem hiding this comment.
What's the difference between true and false here?
There was a problem hiding this comment.
I see, that would nest all children one level deeper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make it the root node, but it wouldn't render properly.
You need to expand Info before, since all it says is the name and whether it's a proto, it's much simpler to just say that straight away.