Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAPI overload that fetches protobuf instead of vdf #1021

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Add WebAPI overload that fetches protobuf instead of vdf #1021

merged 4 commits into from
Oct 7, 2021

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Sep 23, 2021

I only changed the response, not the input.

The api accepts input_protobuf_encoded which means the overload could be changed to accept a proto request.

I updated ContentServerDirectoryService to use this (which by the way, could actually be executed as a service call over CMClient instead).

Thoughts?

Copy link
Member

@yaakov-h yaakov-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it makes sense. Annoyingly that's one more set of generic type arguments to annotate for trimming, but that's the world we live in now.

@yaakov-h
Copy link
Member

yaakov-h commented Oct 7, 2021

I keep coming back to this and having doubts about the name CallAsync<T> which (a) matches the existing CallAsync that returns KeyValue, and (b) isn't constrained and doesn't explain what T is.

We could rename it something like CallAsyncProtoBuf or something but I'm not particularly happy with any other name I've come up with.

Any suggestions, or should we just leave it as is for now?

@yaakov-h yaakov-h merged commit 1310c33 into SteamRE:master Oct 7, 2021
@xPaw xPaw deleted the webapi-protobufs branch October 7, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants