Remove PICSGetProductInfo overloads that takes uint #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose you intended to ping @JustArchi? ;-) |
|
What @archi said 😁 |
JustArchi
approved these changes
Jul 30, 2021
| @@ -185,6 +185,7 @@ public AsyncJob<PICSChangesCallback> PICSGetChangesSince( uint lastChangeNumber | |||
| /// <param name="package">Package id requested.</param> | |||
| /// <param name="metaDataOnly">Whether to send only meta data.</param> | |||
| /// <returns>The Job ID of the request. This can be used to find the appropriate <see cref="PICSProductInfoCallback"/>.</returns> | |||
| [Obsolete( "Use an overload that takes PICSRequest instead of uint. In SteamKit 2.3, this overload had four parameters, but onlyPublic was removed. Audit your code." )] | |||
There was a problem hiding this comment.
I still believe we should just remove this overload entirely right away, so nobody disregards the warning and ends up with broken functionality, but if we really intend to support it then obsoletion mark is still far better than silent breaking change.
|
Sample 9 needs to be updated so that it doesn't use deprecated APIs. There are a few different ways to do this:
|
xPaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JustArchi had a good suggestion to deprecate these overloads, as you really should be requesting app info while providing a token.
I also added an overload that takes one PICSRequest to make migrating easier.