Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set an user-agent for all the web requests that SK2 performs #618

Closed
xPaw opened this issue Dec 22, 2018 · 2 comments
Closed

Set an user-agent for all the web requests that SK2 performs #618

xPaw opened this issue Dec 22, 2018 · 2 comments
Labels
enhancement

Comments

@xPaw
Copy link
Member

xPaw commented Dec 22, 2018

It probably would be a good idea to set it to something like "SteamKit/x.x.x" instead of relying on whatever the runtime the user-agent to be (which would be different depending on version/type/etc).

Maybe it should be exposed in SteamConfiguration so consumers can set it too?
@yaakov-h
Copy link
Member

We could set a default, but consumer configuration should be covered by #605.

@JustArchi
Copy link
Contributor

JustArchi commented Dec 29, 2018 •
edited
Loading

Default request headers was one of the main reasons why I suggested putting HttpClient into SteamConfiguration. Having SK2 default headers when consumer doesn't provide his own HttpClient sounds ok though, but we should ensure to not override the ones in the HttpClient provided by the consumer (even if he didn't set any).

yaakov-h added a commit that referenced this issue Jan 2, 2019
@yaakov-h
Add SteamKit version as default user-agent.
223db10 
Resolves #618.
@yaakov-h yaakov-h mentioned this issue Jan 2, 2019
Merged
heki-ru added a commit to heki-ru/SteamKit that referenced this issue Feb 10, 2019
@heki-ru
sync to latest steamkit (#3)
a00b49d 
* Add SteamKit version as default user-agent.

Resolves SteamRE#618.

* Simplify

* Fix nameof()

* Travis: remove deprecated property

* Fix for NetworkInformationException 

SteamRE#629

* Proper fix 'cause I messed up

* Proper code styling

* Throw an exception if chunk length mismatches

* Add XUnit Analyzers to detect common errors

* Fix xUnit analyzer warnings

* Remove impossible test case

* Keep WebSocketConnection.CurrentEndPoint alive until Disconnected callback is finished

* Add unit test to cover string formatting branch of DebugLog.WriteLine

* "Space space wanna go to space" - Space Core

* Wait there were two of them

* Add changelog and update release link for 2.2 beta

* Update SteamConfigurationBuilder.cs
heki-ru added a commit to heki-ru/SteamKit that referenced this issue Feb 11, 2019
@heki-ru
Test (#5)
5618bb4 
* Add SteamKit version as default user-agent.

Resolves SteamRE#618.

* Simplify

* Fix nameof()

* Travis: remove deprecated property

* Fix for NetworkInformationException 

SteamRE#629

* Proper fix 'cause I messed up

* Proper code styling

* Throw an exception if chunk length mismatches

* Add XUnit Analyzers to detect common errors

* Fix xUnit analyzer warnings

* Remove impossible test case

* Keep WebSocketConnection.CurrentEndPoint alive until Disconnected callback is finished

* Add unit test to cover string formatting branch of DebugLog.WriteLine

* "Space space wanna go to space" - Space Core

* Wait there were two of them

* Add changelog and update release link for 2.2 beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yaakov-h @xPaw @JustArchi