Included protogen is unable to parse "oneof"

[xPaw]

tf_proto_def_messages.proto:119:9: Expected "required", "optional", or "repeated".
tf_proto_def_messages.proto:119:24: Missing field number.

steammessages_hiddevices.proto:99:9: Expected "required", "optional", or "repeated".
steammessages_hiddevices.proto:99:23: Missing field number.

[yaakov-h]

Nothing we can really do,

• Support for "oneof" protobuf-net/protobuf-net#47
• Support of protobuf 2.6 protobuf-net/protobuf-net#54

[SudoHenk]

Seems like "oneof" is not going to be implemented anytime soon. Are there any other options to generate the code from the ProtoBuffs?

[yaakov-h]

I believe oneof doesn't have any different wire encoding to regular fields, so in theory if you replace

oneof a_oneof {
    string first = 1;
    int second = 2;
}

with just

optional first = 1;
optional int second = 2;

then it should work, but you'd have to check in application code which of the fields is set.

[SudoHenk]

protobuf-net:protogen - code generator for .proto
tf_gcmessages.proto:191:16: Option "allow_alias" unknown.
tf_gcmessages.proto:7:8: Option "allow_alias" unknown.

Another problem, seems to be also only present in a newer version of ProtoBuf (I'm still a novice on ProtoBuff and .NET in general, just tried to compile it for the TF2 Update, don't know what the allow_alias option actually does).

[mgravell]

support for oneof in protobuf-net has been there since June (anything 2.3.0 or above): http://blog.marcgravell.com/2017/06/protobuf-net-gets-proto3-support.html

[yaakov-h]

Thanks!

So how do we download/get/build the new protogen? Is there a convenient NuGet package?

[mgravell]

to pre-empt the next question ("how do I get standalone protogen?") (dammit, didn't quite type fast enough - you beat me!):

• option 1: build the "protogen" tool from source - note that the args are now comparable to protoc - this is ideal for people familiar with protoc
• option 2: take a look at the code in protogen's Program.cs (there isn't much) - then add a nuget reference to protobuf-net.Reflection and have fun - this is ideal for custom / automated scenarios
• (edit) option 3: use the online tool https://protogen.marcgravell.com/ - this is ideal for light usage

to pre-empt the question after that ("why isn't there a nuget package for just protogen?"):

because nuget seems to have crappy options for this kind of tool; I'm harassing MS weekly on getting improved tools for build-time codegen.

[yaakov-h]

Not even DotNetCliTool?

[mgravell]

honestly, I've never tried that; if that is an appropriate "fix" here, then I'm more than happy to take a look - especially if there are some reference docs somewhere

[yaakov-h]

The docs for that are here, but I'm not quite sure what to make of them this late at night. 😅

[mgravell]

I'll take a look, thanks

[yaakov-h]

With an new build of protogen, the only way (it seems) to define a namespace is by using option csharp_namespace inside the .proto file. Since these protobufs are reverse-engineered, I don't think we want to mess with them.

I might have to try option 2 above and build our own generator.

[mgravell]

there are some library-specific custom options for controlling that; but I'm not *opposed* to re-adding the options that were there previously

…

On 30 Oct 2017 8:10 a.m., "Yaakov" ***@***.***> wrote: With an new build of protogen, the only way (it seems) to define a namespace is by using option csharp_namespace inside the .proto file. Since these protobufs are reverse-engineered, I don't think we want to mess with them. I might have to try option 2 above and build our own generator. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#478 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABDsBODfiXClvTpAj5MGZwmQdX8brx1ks5sxYRZgaJpZM4QBdnj> .

[xPaw]

Looks like protogen is able to do this now, just need to update it.

[xPaw]

The update is needed now as Valve uses oneof in steammessages_base

https://github.com/SteamDatabase/Protobufs/blob/f6bc595a15b5d9d033196956e7be2fdfa3baa156/steam/steammessages_base.proto#L19-L24

[yaakov-h]

I got back to this... I tried to clean up / finish off #686 but there are bugs in protobuf-net 2.4 so we can't use that.

They seem to be fixed in 3.0 but we're now blocked waiting on this:

protobuf-net/protobuf-net#563

[yaakov-h]

Resolved by #686.