AsyncJob implementations must be completely initialized when they reg…

…ister to AsyncJobManager
SteamRE · Nov 6, 2020 · cf3f91b · cf3f91b
1 parent 117265d
commit cf3f91b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/SteamKit2/SteamKit2/Steam/SteamClient/AsyncJobManager.cs b/SteamKit2/SteamKit2/Steam/SteamClient/AsyncJobManager.cs
@@ -28,6 +28,7 @@ public void StartJob( AsyncJob asyncJob )
         {
             asyncJobs.TryAdd( asyncJob, asyncJob );
         }
+
         /// <summary>
         /// Passes a callback to a pending async job.
         /// If the given callback completes the job, the job is removed from this manager.

diff --git a/SteamKit2/SteamKit2/Types/JobID.cs b/SteamKit2/SteamKit2/Types/JobID.cs
@@ -128,9 +128,17 @@ internal AsyncJob( SteamClient client, JobID jobId )
             jobStart = DateTime.UtcNow;
             JobID = jobId;
 
-            client.StartJob( this );
+
         }
 
+        /// <summary>
+        /// Constructors are required to register this AsyncJob with the JobManager once initialized.
+        /// </summary>
+        /// <param name="client"></param>
+        internal void RegisterJob( SteamClient client )
+        {
+            client.StartJob( this );
+        }
 
         /// <summary>
         /// Adds a callback to the async job's result set.
@@ -178,6 +186,8 @@ public AsyncJob( SteamClient client, JobID jobId )
             : base( client, jobId )
         {
             tcs = new TaskCompletionSource<T>( TaskCreationOptions.RunContinuationsAsynchronously );
+
+            RegisterJob( client );
         }
 
 
@@ -290,6 +300,8 @@ public AsyncJobMultiple( SteamClient client, JobID jobId, Predicate<T> finishCon
             tcs = new TaskCompletionSource<ResultSet>( TaskCreationOptions.RunContinuationsAsynchronously );
 
             this.finishCondition = finishCondition;
+
+            RegisterJob( client );
         }